Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughSelectLineScreen.tsxのlineSelection関連メソッドにおいて、pendingStationおよびpendingStationsの状態管理フローが改変されました。handleLineSelectedとopenModalByLineIdの両メソッドで、ステーション情報をクリアしてから再度フェッチして再入力する2段階更新パターンが導入されました。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/screens/SelectLineScreen.tsx (1)
565-596:⚠️ Potential issue | 🟠 Major最新のリクエストのみを反映させるガードが必要
Line 584-596 の非同期フェッチ中に再度カード選択されると、古いレスポンスで状態が上書きされる可能性があります。
fetchStationsByLineIdLoadingが true のときはスケルトンで保護されますが、フェッチ完了後に再び CommonCard が表示される際、CommonCard のloadingプロップは onPress を無効化しません。そのため以下のシナリオが発生します：
- 線A を選択 → フェッチ開始
- フェッチ完了 →
fetchStationsByLineIdLoadingが false に- CommonCard 再表示（モーダル開いたまま）
- 線B を選択 → 別フェッチ開始
- 線B のレスポンスが後に到着 → 線A のデータを上書き
Line 592-596 の状態更新時に
lineIdの一致をチェックするか、フェッチ中はカードへのタップを無効化する対策を検討してください。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/screens/SelectLineScreen.tsx` around lines 565 - 596, Save the current requested lineId into a local variable before calling fetchStationsByLineId (e.g. const requestLineId = lineId) and after the await return, check that the response matches the latest selected line (compare requestLineId to the current pending/selected line id from state, e.g. lineState.pendingLine?.id or stationState.pendingStation?.lineId) and abort setting pendingStation/pendingStations if they differ; alternatively also disable CommonCard onPress while fetchStationsByLineIdLoading is true so taps are ignored during an ongoing fetch. Ensure you update the code around setLineState, fetchStationsByLineId and the setStationState block to perform this guard.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/screens/SelectLineScreen.tsx`:
- Around line 565-596: Save the current requested lineId into a local variable
before calling fetchStationsByLineId (e.g. const requestLineId = lineId) and
after the await return, check that the response matches the latest selected line
(compare requestLineId to the current pending/selected line id from state, e.g.
lineState.pendingLine?.id or stationState.pendingStation?.lineId) and abort
setting pendingStation/pendingStations if they differ; alternatively also
disable CommonCard onPress while fetchStationsByLineIdLoading is true so taps
are ignored during an ongoing fetch. Ensure you update the code around
setLineState, fetchStationsByLineId and the setStationState block to perform
this guard.
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Summary by CodeRabbit
リリースノート